Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an input consistency check. #5209

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Nov 6, 2024

Proposed changes

No deterministic tests got flagged.

What type(s) of changes does this code introduce?

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

laptop

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted

Error out when user accidentally chooses fractional coordinates without specifying a lattice.
@ye-luo
Copy link
Contributor Author

ye-luo commented Nov 6, 2024

Test this please

Copy link
Contributor

@PDoakORNL PDoakORNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ye-luo ye-luo merged commit e51f528 into QMCPACK:develop Nov 6, 2024
42 of 43 checks passed
@ye-luo ye-luo deleted the more-input-check branch November 6, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants