Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch macOS CI #4948

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Patch macOS CI #4948

merged 2 commits into from
Apr 29, 2024

Conversation

williamfgc
Copy link
Contributor

Proposed changes

Address Homebrew and Python issues on macOS GitHub Actions runner

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Must pass CI

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@williamfgc williamfgc changed the title Patch macOS CI [WIP] Patch macOS CI Mar 28, 2024
@williamfgc williamfgc force-pushed the ci-macos-patch branch 2 times, most recently from c04590f to e84b06c Compare March 28, 2024 16:54
@williamfgc williamfgc changed the title [WIP] Patch macOS CI Patch macOS CI Mar 28, 2024
@williamfgc
Copy link
Contributor Author

Similar issue to Homebrew/homebre-core#165793

@williamfgc
Copy link
Contributor Author

Test this please

@williamfgc williamfgc force-pushed the ci-macos-patch branch 2 times, most recently from 2c840e4 to 6a9715e Compare March 28, 2024 18:44
@williamfgc williamfgc changed the title Patch macOS CI [WIP] Patch macOS CI Mar 28, 2024
@prckent
Copy link
Contributor

prckent commented Apr 29, 2024

@williamfgc Are you OK to un-WIP this and have it merged? While macos builds are now fixed, this still seems like a healthy update that we would have to do at some point.

@prckent
Copy link
Contributor

prckent commented Apr 29, 2024

Test this please

@williamfgc williamfgc changed the title [WIP] Patch macOS CI Patch macOS CI Apr 29, 2024
@williamfgc
Copy link
Contributor Author

@prckent removed WIP. Thanks!

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prckent prckent merged commit 9d71a1e into QMCPACK:develop Apr 29, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants