Nexus: Use simplices in convex_hull #4671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prckent
changed the title
|
Test this please |
jtkrogel
previously requested changes
Jul 12, 2023
|
Test this please |
1 similar comment
|
Test this please |
|
It looks like "simplices" was added in scipy 0.12 (released in 2013) |
markdewing
approved these changes
Jul 12, 2023
|
test this please |
prckent
dismissed
jtkrogel’s stale review
This was fully addressed. DIsmissing so that this can be merged without bothering anyone again.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes #4670
This looks to be a trivial fix ; vertices was removed in scipy 1.11.0 https://docs.scipy.org/doc/scipy/release/1.11.0-notes.html#expired-deprecations . However I did not yet find the version when simplices was introduced - is it old enough?
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
sulfur, nightly config
Checklist