Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix offload when partial J1 is specified #4405

Merged
merged 4 commits into from
Jan 20, 2023
Merged

Fix offload when partial J1 is specified #4405

merged 4 commits into from
Jan 20, 2023

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Jan 20, 2023

Proposed changes

Make J1 with partial elements to work and issue warnings when it happens.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

prckent
prckent approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prckent
Copy link
Contributor

prckent commented Jan 20, 2023

Test this please

@prckent prckent enabled auto-merge January 20, 2023 21:02
@prckent prckent merged commit 314c77e into QMCPACK:develop Jan 20, 2023
@ye-luo ye-luo deleted the fix-batch-partialJ1 branch January 21, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prckent prckent prckent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ye-luo @prckent