Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unversioned cuda in test script #4296

Closed
wants to merge 1 commit into from

Conversation

prckent
Copy link
Contributor

@prckent prckent commented Oct 27, 2022

Proposed changes

Use generic /cuda/ in script. Old CUDA versions no longer installed on test system. See if bug is fixed.

The relevant lines are kept in case future customization is needed.

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

None

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • NA. Code added or changed in the PR has been clang-formatted
  • NA. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • NA. Documentation has been added (if appropriate)

Copy link
Contributor

@williamfgc williamfgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see if the regression is still there on 11.8

@prckent
Copy link
Contributor Author

prckent commented Oct 27, 2022

Test this please

@prckent
Copy link
Contributor Author

prckent commented Oct 27, 2022

Unfortunately the problem is still there in 11.8. Lets install 11.2 for now to keep things moving in CI. Still need some policy to highlight this problem llvm/llvm-project#54633

@prckent prckent closed this Oct 27, 2022
@prckent prckent deleted the no_fixed_cuda branch January 14, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants