Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references for statistical integration test and deterministic test for diamond #4218

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

Hyeondeok-Shin
Copy link
Contributor

Proposed changes

This PR is to update reference values for statistical integration test for diamond to fix some failure in the test on cdash. Confirming all tests are passed on the workstation.
Also, tolerance for deterministic test on mixed precision build is updated to make test pass.

Close #4162.

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Intel Xeon

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • Yes. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hyeondeok

@prckent
Copy link
Contributor

prckent commented Sep 1, 2022

Test this please

@prckent prckent enabled auto-merge September 1, 2022 14:29
@prckent prckent merged commit d28127d into QMCPACK:develop Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remaining spline spo excited state tests update
2 participants