Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove macro HAVE_LIBHDF5 #4163

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Conversation

quantumsteve
Copy link
Contributor

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here
with a supported keyword.

Removes the macro HAVE_LIBHDF5 which is always true.

Fixes #4155

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • Refactoring (no functional changes, no api changes)
  • Build related changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted

Signed-off-by: Steven Hahn <hahnse@ornl.gov>
@quantumsteve quantumsteve requested a review from ye-luo August 9, 2022 14:34
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
@ye-luo
Copy link
Contributor

ye-luo commented Aug 9, 2022

Test this please

@ye-luo ye-luo enabled auto-merge August 9, 2022 17:06
@ye-luo ye-luo merged commit 6c09b89 into QMCPACK:develop Aug 9, 2022
@quantumsteve quantumsteve deleted the have_libhdf5 branch August 9, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove macro HAVE_LIBHDF5
2 participants