Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce NVHPC warning #4031

Merged
merged 1 commit into from
May 26, 2022
Merged

Reduce NVHPC warning #4031

merged 1 commit into from
May 26, 2022

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented May 26, 2022

Proposed changes

It seems the code base is also improved.

What type(s) of changes does this code introduce?

  • Other (please describe):

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-server

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo
Copy link
Contributor Author

ye-luo commented May 26, 2022

Test this please

PDoakORNL
PDoakORNL approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@PDoakORNL PDoakORNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style wise I prefer most of these changes. Never been a fan of unreachable returns and breaks.

@ye-luo ye-luo enabled auto-merge May 26, 2022 00:26
@ye-luo ye-luo merged commit 5bd1f00 into QMCPACK:develop May 26, 2022
ye-luo added a commit to ye-luo/qmcpack that referenced this pull request May 26, 2022
@ye-luo
Revert unintended change in PR QMCPACK#4031
345193d
@ye-luo ye-luo mentioned this pull request May 26, 2022
Merged
@ye-luo ye-luo deleted the nvhpc-reduce-warning branch June 27, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PDoakORNL PDoakORNL PDoakORNL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ye-luo @PDoakORNL