-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add one dim cubic spline with linear grid #3839
Add one dim cubic spline with linear grid #3839
Conversation
Test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why is this needed?
- Add comments/definitions
- Class not struct?
- Private not public
- Hopefully 100% test coverage
class containing pointers with virtual function pointer calls. I'd like to stay away from them inside a GPU kernel.
I will add more.
Will do
I hope so. |
It is 90.90% unfortunately not 100%. |
Good try on the coverage. Can you put a note about avoiding virtual functions for future people using/modifying this? |
I added a note explaining that this class was made to avoid virtual functions on GPU and how the member functions should be used. |
Test this please |
Proposed changes
To be used in short range Coulomb PBC AA.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist