Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deterministic test of 2x1x1 diamond for plane-wave #3771

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

Hyeondeok-Shin
Copy link
Contributor

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Close #3105.

This PR is to add plane-wave test for 2x1x1 diamond to provide coverage of plane-wave in deterministic test.

What type(s) of changes does this code introduce?

  • Other (please describe): Add test

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Intel Xeon workstation

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • Yes. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No Documentation has been added (if appropriate)

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hyeondeok. Approved subject to CI.

When this gets merged please keep an eye on the nightlies and adjust the error bars appropriately.

@prckent
Copy link
Contributor

prckent commented Jan 26, 2022

Test this please

@prckent prckent merged commit a04d2a9 into QMCPACK:develop Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deterministic plane wave test (low priority)
2 participants