Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nexus install path. #3725

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Fix nexus install path. #3725

merged 2 commits into from
Jan 12, 2022

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Jan 12, 2022

Proposed changes

fixes #3720
Prevent path being translated at CMake step.
The desired path will show up in build/cmake_install.cmake and become effective at make install.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-server

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@prckent
Copy link
Contributor

prckent commented Jan 12, 2022

Start testing in-house

@prckent
Copy link
Contributor

prckent commented Jan 12, 2022

Interesting unrelated CI failure?

@ye-luo
Copy link
Contributor Author

ye-luo commented Jan 12, 2022

Interesting unrelated CI failure?

Error shows

cudaAssert: cudaErrorMemoryAllocation out of memory*** file /scratch/ci/actions-runner/_work/qmcpack/qmcpack/src/Platforms/CUDA/CUDAallocator.hpp*** line 278

Probably just unlucky that the nightly tests are using the GPU at the same time.

@ye-luo
Copy link
Contributor Author

ye-luo commented Jan 12, 2022

Test this please

@prckent
Copy link
Contributor

prckent commented Jan 12, 2022

I verified that no nightlies are currently using the Volta used for this CI, so the current rerun should work.

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prckent prckent merged commit a6ecd88 into QMCPACK:develop Jan 12, 2022
@ye-luo ye-luo deleted the fix-nexus-install branch January 19, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'install' target fails to install nexus but still succeeds
2 participants