Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus: Small fix to excitation checks #3701

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

mcbennet
Copy link
Contributor

@mcbennet mcbennet commented Jan 3, 2022

Proposed changes

This PR provides a fix to an off-by-one error when checking that the einspline files contain the correct excitation.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No. All nxs-test tests pass

What systems has this change been tested on?

ALCF Theta

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • N/A. Code added or changed in the PR has been clang-formatted
  • N/A. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • N/A. Documentation has been added (if appropriate)

@ye-luo
Copy link
Contributor

ye-luo commented Jan 3, 2022

Test this please

@ye-luo ye-luo merged commit fbbe1d0 into QMCPACK:develop Jan 3, 2022
@mcbennet mcbennet deleted the nxs_fix_exc_check branch January 4, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants