Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus: Allow bandstructure plotting with custom k-path #3293

Merged
merged 4 commits into from
Jul 17, 2021

Conversation

mcbennet
Copy link
Contributor

Proposed changes

This PR adds to the function plot_bandstructure in ./nexus/lib/pwscf_analyzer.py. It allows the user to provide a custom set of labels for the high symmetry k-points (in the form k_labels=['GAMMA','','','','M','','',...]) where the length of the label array should match the number of k-points in the analyzer object. When custom labels are give, spglib is no longer used since it is assume that the k-points in the analyzer object are different from the ones that would be generated by spglib.

What type(s) of changes does this code introduce?

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Laptop. Linux

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • N/A. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@qmc-robot
Copy link

Can one of the admins verify this patch?

@prckent
Copy link
Contributor

prckent commented Jul 15, 2021

We should probably add this to the PR template: are any python package dependencies changed?

@mcbennet
Copy link
Contributor Author

We should probably add this to the PR template: are any python package dependencies changed?

None of the dependencies are altered.

@ye-luo
Copy link
Contributor

ye-luo commented Jul 17, 2021

Test this please

@ye-luo ye-luo enabled auto-merge July 17, 2021 18:19
@ye-luo ye-luo merged commit c6ddb24 into QMCPACK:develop Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants