Pade2 bug fix #3256
Merged
Pade2 bug fix #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I see this breaks complex builds. I'll take another look |
ye-luo
reviewed
Jul 14, 2021
ye-luo
approved these changes
Jul 14, 2021
| { | ||
| real_type br(B * r); | ||
| return (A + br) * r / (1.0 + br); |
|
Test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The manual describes a pade2 functor (at least for 1 body Jastrows). At some point along the way this functionality got dropped. This puts it back in and cleans some things up.
This builds upon #3243 so this doesn't need to be reviewed until that is sorted out.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Ryzen workstation
Checklist