-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference Space Warp Transformation for ZVZB Forces #2828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clang-format the modified source code will also be helpful.
@ye-luo OK. Short of the making ions "const" issue and the default behavior of evaluateDeterministic, I believe I have addressed all your concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for helping with the code quality improvements. Only a few minor issues left.
Proposed changes
This implements a preliminary reference version of the space-warp transformation for ZVZB force estimators, given in https://doi.org/10.1063/1.3516208. Currently, Grad_i(E_L) w.r.t. electron coordinates is handled through finite differences, but replacement with analytic derivatives should reasonably occur within the current infrastructure.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Local intel Xeon server.
Checklist