Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling of XML include. #1426

Merged
merged 2 commits into from
Mar 8, 2019

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Mar 8, 2019

Close #1423
Now the code stops correctly reporting the following without a crash.

I/O warning : failed to load external entity "PTCL_XML"
ERROR File PTCL_XML is invalid
I/O warning : failed to load external entity "WFS_XML"
ERROR File WFS_XML is invalid
ERROR ERROR: No target particle e exists.
ERROR Illegal input. Missing particleset 
ERROR Input document does not contain valid objects

@ghost ghost assigned ye-luo Mar 8, 2019
@ghost ghost added the in progress label Mar 8, 2019
@prckent
Copy link
Contributor

prckent commented Mar 8, 2019

Can we hard abort after "ERROR File PTCL_XML is invalid"? No use to continue processing.

@ye-luo
Copy link
Contributor Author

ye-luo commented Mar 8, 2019

Now

I/O warning : failed to load external entity "PTCL_XML"
ERROR File PTCL_XML is invalid
application called MPI_Abort(world, 1) - process 0

@ye-luo
Copy link
Contributor Author

ye-luo commented Mar 8, 2019

Test this please

@ye-luo ye-luo merged commit afd9c47 into QMCPACK:develop Mar 8, 2019
@ghost ghost removed the in progress label Mar 8, 2019
@ye-luo ye-luo deleted the fix-include-error-handling branch March 9, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants