Fix TM1/3 when using both batched algorithm and delayed updates #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ye-luo
commented
Feb 26, 2019
ye-luo
commented
- Fix Tmove v1 and v3 when using both batched algorithm and delayed updates
- Move the state machine invRow_id to the DiracDeterminat class
- ratio, ratioGrad, evalGrad inside DelayedUpdate class is not necessary and moved back to DiracDeterminat.
Move the state machine out to DiracDeterminant.
ghost
assigned 
prckent
reviewed
Feb 27, 2019
| RatioTimer.stop(); | ||
|
|
||
| // check invRow_id against WorkingIndex to ensure getInvRow() called before ratioGrad() | ||
| // This is not a safety check. Some code paths do call ratioGrad without calling evalGrad first. |
There was a problem hiding this comment.
Commentary: Unfortunate that this is needed, but how would anyone ever know to call evalGrad before calling ratioGrad?
There was a problem hiding this comment.
Good point. I have update the comment which is more clear as an optimization.
prckent
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.