-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to multi array in AFQMC #1291
Conversation
Can one of the maintainers verify this patch? |
There's a small bug fix to boost-multi/multi/array_ref.hpp, |
OK to test |
Do we still use boost's and Afredo's multi array? Or no more boost one? |
Alfredo's multi should replace boost's multi_array entirely. There should
be no more usage of boost's multi_array.
If anything is left it is because I missed it.
For example, writing this I realized that I didn't removed the template
specializations for boost's multi_array in the hdf and type_traits folders.
I still need boost, because I use boost::variant and boost::iterator.
When we move to c++17, I can stop relying on boost entirely.
…On Thu, Jan 3, 2019 at 6:57 PM Ye Luo ***@***.***> wrote:
Do we still use boost and Afredo's multi array? Or no more boost one?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1291 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEdZj3He3rIou1n-Z2II9zVUVXiUbW1lks5u_sMsgaJpZM4Zolc7>
.
|
@mmorale3 Thank you. Please remove the left non used code when you have time. Your explanation made the status of multi_array very clear. It is great that hana is gone. We won't remove the dependency of boost until all your needs are covered by C++. |
Switch to multi array in AFQMC
Completes switch to Alfredo's multi array library in AFQMC. Removes boost::hanna which should fix build errors.