Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to multi array in AFQMC #1291

Merged
merged 4 commits into from
Jan 3, 2019
Merged

Conversation

fdmalone
Copy link
Contributor

@fdmalone fdmalone commented Jan 3, 2019

Completes switch to Alfredo's multi array library in AFQMC. Removes boost::hanna which should fix build errors.

@qmc-robot
Copy link

Can one of the maintainers verify this patch?

@mmorale3
Copy link
Contributor

mmorale3 commented Jan 3, 2019

There's a small bug fix to boost-multi/multi/array_ref.hpp,
will be updated with official library after Alfredo makes the fix on his end.

@prckent prckent changed the title Switch to multi Switch to multi array in AFQMC Jan 3, 2019
@prckent
Copy link
Contributor

prckent commented Jan 3, 2019

OK to test

@mmorale3 mmorale3 merged commit 9632a83 into QMCPACK:develop Jan 3, 2019
@mmorale3 mmorale3 deleted the switch_to_multi branch January 3, 2019 20:14
@ye-luo
Copy link
Contributor

ye-luo commented Jan 4, 2019

Do we still use boost's and Afredo's multi array? Or no more boost one?

@mmorale3
Copy link
Contributor

mmorale3 commented Jan 4, 2019 via email

@ye-luo
Copy link
Contributor

ye-luo commented Jan 4, 2019

@mmorale3 Thank you. Please remove the left non used code when you have time. Your explanation made the status of multi_array very clear. It is great that hana is gone. We won't remove the dependency of boost until all your needs are covered by C++.

@ye-luo ye-luo mentioned this pull request Jan 4, 2019
fdmalone pushed a commit to mmorale3/qmcpack that referenced this pull request Jan 7, 2019
@camelto2 camelto2 mentioned this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants