Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test failing on BGQ #941

Closed
ye-luo opened this issue Jul 30, 2018 · 2 comments
Closed

Unit test failing on BGQ #941

ye-luo opened this issue Jul 30, 2018 · 2 comments
Assignees
@markdewing
Labels
bug

Comments

@ye-luo
Copy link
Contributor

ye-luo commented Jul 30, 2018

From last night,
test_unit_spline2 fails with mixed precision build and hangs with full precision build.
https://cdash.qmcpack.org/CDash/testDetails.php?test=2803958&build=26247
test_particle has kc = nan
https://cdash.qmcpack.org/CDash/testDetails.php?test=2803962&build=26247
@ye-luo
Copy link
Contributor Author

ye-luo commented Jul 30, 2018

@markdewing Will you have time to have a look at the spline2 since you created it?

@markdewing
Copy link
Contributor

Yes, I can look at it.

@markdewing markdewing self-assigned this Jul 30, 2018
@jtkrogel jtkrogel added the bug label Jul 31, 2018
markdewing added a commit to markdewing/qmcpack that referenced this issue Jul 31, 2018
@markdewing
Allocate more space for laplacian in spline test.
39dd3cb 
The laplacian is stored as x, y, and z components during the spline evaluation and
summed into the x component at the end.    Need to allocate more space for it in the unit test.

Fixes QMCPACK#941
markdewing added a commit to markdewing/qmcpack that referenced this issue Aug 2, 2018
@markdewing
Fix spline test for SoA and BGQ.
b23691b 
Increase num_splines to ensure correct alignment on BG/Q.

Rearrange the test accesses to gradients and hessians to match the SoA layout.

Should fix QMCPACK#941
@markdewing markdewing mentioned this issue Aug 2, 2018
Merged
@ghost ghost added the in progress label Aug 2, 2018
@ghost ghost removed the in progress label Aug 3, 2018
@tiihonej tiihonej mentioned this issue Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markdewing markdewing

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@markdewing @ye-luo @jtkrogel