[CMake] Rename ENABLE_HIP to BUILD_AFQMC_HIP

[ye-luo]

Proposed changes

ENABLE_HIP was introduced by AFQMC for non-CUDA HIP-explicit source code.
In the current setting, ENABLE_ROCM is the switch to enable hip compilers and rocm libraries.
Thus, rename ENABLE_HIP to BUILD_AFQMC_HIP to reduce confusion.
Note that unfortunately, the current code cannot compile with this option on.

What type(s) of changes does this code introduce?

• Build related changes

Does this introduce a breaking change?

• No

What systems has this change been tested on?

epyc-server

Checklist

• Yes. This PR is up to date with current the current state of 'develop'

[ye-luo]

Test this please

[prckent]

Obligatory and unsurprising questions and comments: any idea when this last worked? What is broken? Does it look easy to repair? This option unfortunately did not make it to the documentation or any test configuration.

I agree with the renaming.

[ye-luo]

Obligatory and unsurprising questions and comments: any idea when this last worked? What is broken? Does it look easy to repair? This option unfortunately did not make it to the documentation or any test configuration.

I agree with the renaming.

Probably 4 years ago, beginning of 2021.
Any breakage caused by QMCPACK source code change over the years should be easily fixed.
Any breakage due to ROCm changes won't be easy to addressed.

[ye-luo]

Test this please

[prckent]

• Please add a mention in the docs of this configuration option -- a key reason how this was broken.
• Add an issue reporting BUILD_AFQMC_HIP as broken so we can track it/a user of AFQMC might find it and perhaps repair it.

[ye-luo]

• Please add a mention in the docs of this configuration option -- a key reason how this was broken.

  • Add an issue reporting BUILD_AFQMC_HIP as broken so we can track it/a user of AFQMC might find it and perhaps repair it.

both items completed.

[ye-luo]

Test this please

[prckent]

Thanks Ye