Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2022-12-fix-testdata add ilival.logs / add dataset with errors #87

Merged
merged 4 commits into from
Dec 23, 2022
Merged

2022-12-fix-testdata add ilival.logs / add dataset with errors #87

merged 4 commits into from
Dec 23, 2022

Conversation

sjib
Copy link
Contributor

@sjib sjib commented Nov 30, 2022

  • testing testdata behaviour
  • adding a ilival.log for all datasets
  • adding dataset withour errors: case_c_import_all_without_errors.xtf

sjib added 2 commits November 30, 2022 07:57
@sjib
add ilival.logs / add dataset with errors
7733fcd
@sjib
Added case d
bda811f 
-  def test_case_d_import_complete_xtf_to_qgep(self):
- case_d_import_all_without_errors.xtf (neu case d in filename)
@sjib sjib changed the title add ilival.logs / add dataset with errors 2022-12-fix-testdata add ilival.logs / add dataset with errors Dec 13, 2022
@sjib
Copy link
Contributor Author

sjib commented Dec 13, 2022

  • def test_case_d_import_complete_xtf_to_qgep(self):
  • case_d_import_all_without_errors.xtf (new case d in filename)

@sjib sjib requested a review from olivierdalang December 13, 2022 11:06
olivierdalang
olivierdalang reviewed Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@olivierdalang olivierdalang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add the *.log files ? I don't see them used in the tests ?

qgepqwat2ili/tests/test_qgep.py Show resolved Hide resolved
@sjib
Copy link
Contributor Author

sjib commented Dec 19, 2022

@olivierdalang I removed the failing test and deleted the log as discussed at the technical meeting last week. Can you merge?

@ponceta ponceta merged commit 234d83f into master Dec 23, 2022
@ponceta ponceta deleted the 2022-12-fix-testdata branch December 23, 2022 13:43
@ponceta
Copy link
Member

ponceta commented Dec 23, 2022

@sjib merged.

@ponceta ponceta added the documentation Improvements or additions to documentation label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierdalang olivierdalang olivierdalang left review comments

Assignees

@sjib sjib

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjib @ponceta @olivierdalang