Prepare for baskets #180
Merged
Prepare for baskets #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domi4484
force-pushed
the
prepareForBaskets
branch
from
cf71c52 to
e8fc43f
Compare
|
@ponceta If you agree I would like to merge this already to avoid having a too big growing PR |
ponceta
approved these changes
Nov 20, 2024
|
Thank you @domi4484 , this is really great work and will help a lot around the bugfixing tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change anything yet but just prepare the fundamentals to enable the export with baskets, needed for ili dist upgrade (#138)
Bonus it regroups some code that was copied over 3 different export files.
Follow up work should enable export with baskets for dss and kek