Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log only when debug mode is active #170

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Log only when debug mode is active #170

merged 2 commits into from
Oct 18, 2024

Conversation

ponceta
Copy link
Member

@ponceta ponceta commented Oct 18, 2024

Log only when debug mode is active

Ref for dev docs :

https://docs.python.org/3.12/howto/logging.html

Log only when debug mode is active
@ponceta ponceta requested a review from sjib October 18, 2024 08:11
@ponceta ponceta self-assigned this Oct 18, 2024
@ponceta ponceta removed the request for review from sjib October 18, 2024 08:16
Log only on debug or warning for check_fk_in_subsetid
@sjib
Copy link
Contributor

sjib commented Oct 18, 2024

@ponceta So is this connected to these settings?
grafik

And in conclusion if we do testing we would have to chane these setting?

@ponceta
Copy link
Member Author

ponceta commented Oct 18, 2024

Yes, this is the best way to proceed.

The only thing missing is when using command line this parameter should be set in some way! But it should solve the issue for most of the users.

@ponceta ponceta requested a review from sjib October 18, 2024 09:21
Copy link
Contributor

@sjib sjib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ponceta Thanks - that looks plausible to me

@ponceta ponceta merged commit 6ff9fa4 into master Oct 18, 2024
5 checks passed
@ponceta ponceta deleted the poa_fix_messages branch October 18, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants