Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create vw_infiltration_installation and vw_wwtp_structure views #189

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

rbovard
Copy link
Contributor

@rbovard rbovard commented Nov 9, 2022

Fix QGEP/QGEP#768

Create vw_infiltration_installation and vw_wwtp_structure views.

Please double check the diff file, I created it manually.

BTW, is there a way to automatically create this diff (maybe with PUM)?

@ponceta
Copy link
Member

ponceta commented Dec 6, 2022

@rbovard Nope nope nope, no delta is required on views, that's precisely why we drop and create these dynamically.

Without the delta CI should be fine!

@ponceta ponceta self-requested a review December 6, 2022 10:39
@rbovard
Copy link
Contributor Author

rbovard commented Dec 6, 2022

@rbovard Nope nope nope, no delta is required on views, that's precisely why we drop and create these dynamically.

Done.

For the record, I did what @sjib instructed me to do but I was not comfortable creating this delta by hand...

@sjib
Copy link
Contributor

sjib commented Dec 6, 2022

@rbovard My fault with the delta. Just for datamodel changes.

@ponceta
Copy link
Member

ponceta commented Dec 6, 2022

CI is happy, safe to merge since this is only two additionnal views.

@ponceta ponceta merged commit e94fef6 into QGEP:master Dec 6, 2022
@ponceta ponceta mentioned this pull request Dec 6, 2022
24 tasks
@ponceta
Copy link
Member

ponceta commented Dec 6, 2022

Thank you @rbovard !

@rbovard rbovard deleted the new-views branch December 6, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create 2 missing views
3 participants