Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualify total_cross_section calls #80

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

AntonReinhard
Copy link
Member

Since total_cross_section moves to QEDbase, we need to qualify the calls here for now in order for integration tests to work.

Once we remove the implementation here, the QEDbase. calls will automatically fail and need to be removed as well.

@AntonReinhard AntonReinhard requested a review from szabo137 June 21, 2024 12:03
@AntonReinhard AntonReinhard mentioned this pull request Jun 21, 2024
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@szabo137 szabo137 merged commit a864c16 into QEDjl-project:dev Jun 21, 2024
4 checks passed
@szabo137 szabo137 added this to the Release-next milestone Jul 15, 2024
@szabo137 szabo137 added the 09 - Maintenance Related to maintenance, housekeeping, repo-config label Jul 15, 2024
@AntonReinhard AntonReinhard deleted the fix_ambiguous_total_cs branch September 2, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
09 - Maintenance Related to maintenance, housekeeping, repo-config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants