Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: add new compat entry for Roots at version 2, (keep existing compat) #95

Conversation

github-actions[bot]
Copy link
Contributor

This pull request sets the compat entry for the Roots package to 2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

@AntonReinhard AntonReinhard force-pushed the compathelper/new_version/2025-01-30-01-28-38-930-00781175568 branch from 7ef21d8 to e63eac3 Compare January 30, 2025 01:28
@SimeonEhrig SimeonEhrig force-pushed the compathelper/new_version/2025-01-30-01-28-38-930-00781175568 branch from d384e4d to d7ea329 Compare January 30, 2025 13:51
@AntonReinhard
Copy link
Member

@SimeonEhrig was your push to this branch intentional?

@AntonReinhard AntonReinhard marked this pull request as draft January 31, 2025 13:32
@AntonReinhard AntonReinhard force-pushed the compathelper/new_version/2025-01-30-01-28-38-930-00781175568 branch from d7ea329 to e63eac3 Compare February 1, 2025 12:07
@SimeonEhrig
Copy link
Member

@SimeonEhrig was your push to this branch intentional?

Yes, I need the branch to fix the bug in the CI Bootloader.jl script. That's the reason why I overwrote the the gitlab-ci.yml: d384e4d

@SimeonEhrig
Copy link
Member

@AntonReinhard Last week, the CI was not reporting back. Now, I see my fix solved the problem. I open the PR, we merge it, I undo the last commit and the CI should pass with the default Bootloader.jl URL and branch.

@AntonReinhard
Copy link
Member

@AntonReinhard Last week, the CI was not reporting back. Now, I see my fix solved the problem. I open the PR, we merge it, I undo the last commit and the CI should pass with the default Bootloader.jl URL and branch.

Ah I see. Sorry for deleting it before.

szabo137 pushed a commit to QEDjl-project/QuantumElectrodynamics.jl that referenced this pull request Feb 3, 2025
@SimeonEhrig SimeonEhrig force-pushed the compathelper/new_version/2025-01-30-01-28-38-930-00781175568 branch from d7ea329 to e63eac3 Compare February 3, 2025 10:04
@SimeonEhrig SimeonEhrig marked this pull request as ready for review February 3, 2025 11:11
@AntonReinhard AntonReinhard merged commit 4c8ef31 into dev Feb 3, 2025
8 checks passed
@AntonReinhard AntonReinhard deleted the compathelper/new_version/2025-01-30-01-28-38-930-00781175568 branch February 3, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants