Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase Space Layout #70

Merged
merged 15 commits into from
Oct 30, 2024
Merged

Phase Space Layout #70

merged 15 commits into from
Oct 30, 2024

Conversation

szabo137
Copy link
Member

@szabo137 szabo137 commented Oct 18, 2024 •
edited
Loading

This PR adds the phase space layout interface and a convenient user-faced API for working with coordinate maps for given processes, models, and phase space layouts.

TODO:

  • clean up (remove the TODOs in the files)
  • unify the calls of coordinate maps (are the different implementations for in- and out-PSL vital?)
  • add validity checks to the interface and construction of the coordinate maps
  • fix the docs
  • move patch_QEDbase.jl to QEDbase

@szabo137 szabo137 marked this pull request as draft October 18, 2024 09:43
@szabo137
Copy link
Member Author

@AntonReinhard Most of the todos above could also be moved into an issue and checked later 🤷‍♂️
So if you like, you can review this, even though it is in draft mode.

@szabo137 szabo137 force-pushed the dev-phase_space_layout branch from 30c8fe7 to f15a500 Compare October 21, 2024 13:48
AntonReinhard
AntonReinhard reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/coordinate_map/cached.jl Outdated Show resolved Hide resolved
tmp.jl Outdated Show resolved Hide resolved
@szabo137 szabo137 force-pushed the dev-phase_space_layout branch 3 times, most recently from 6605265 to 5443246 Compare October 28, 2024 19:51
@szabo137 szabo137 force-pushed the dev-phase_space_layout branch from 1e8d2ff to a09a6cc Compare October 28, 2024 20:28
@szabo137 szabo137 marked this pull request as ready for review October 29, 2024 14:15
@szabo137 szabo137 mentioned this pull request Oct 29, 2024
Merged
4 tasks
@szabo137 szabo137 changed the title [WIP] Phase Space Layout Phase Space Layout Oct 29, 2024
@szabo137
Copy link
Member Author

@AntonReinhard Is there anything to do with this? If not, I would like to proceed 🙆‍♂️

AntonReinhard
AntonReinhard approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side

@szabo137 szabo137 merged commit 81d1025 into QEDjl-project:dev Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonReinhard AntonReinhard AntonReinhard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szabo137 @AntonReinhard