Add @inline to some functions #65
Merged
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AntonReinhard
force-pushed
the
assume-effects
branch
from
cb1daa7 to
3668e99
Compare
|
This is stale for now and I'll come back to it at some other time. Currently this should not be merged since the assumptions aren't safe to make. |
AntonReinhard
force-pushed
the
assume-effects
branch
2 times, most recently
from
3c5041a to
d373092
Compare
|
I have removed the unsafe assumptions for now and only added some |
AntonReinhard
changed the title
AntonReinhard
force-pushed
the
assume-effects
branch
from
d373092 to
2d5d092
Compare
AntonReinhard
force-pushed
the
assume-effects
branch
from
2d5d092 to
177ce10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dangerous and we should instead find the actual reason for the inconsistency. I'll leave this as a draft for now and will look into it more later. Since
Base.@assume_effectsrequires Julia 1.8 this will fail unit tests anyways.Having these functions infer
:consistentcorrectly by the compiler can significantly help with optimization in the compiler, so eventually we should try to make sure that most of QEDcore functionality has as many effects inferred as possible.Edit: I have removed the assumptions again because they are not safe to make (at least not for all element types). We should come back to this at a later point. For now, I have only added some
@inboundsstatements.