Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the mul function #42

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Hide the mul function #42

merged 1 commit into from
Aug 9, 2024

Conversation

AntonReinhard
Copy link
Member

Rename the mul function to _mul since it is not exported.
Goes together with QEDjl-project/QEDbase.jl#110

@AntonReinhard AntonReinhard requested a review from szabo137 August 9, 2024 11:03
szabo137
szabo137 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me 🙆‍♂️

@AntonReinhard AntonReinhard changed the title Hides the mul function Hide the mul function Aug 9, 2024
@AntonReinhard AntonReinhard merged commit 00784a7 into QEDjl-project:dev Aug 9, 2024
3 checks passed
@AntonReinhard AntonReinhard deleted the hide-mul-function branch August 9, 2024 13:47
@AntonReinhard AntonReinhard added this to the Release-next milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabo137 szabo137 szabo137 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release-0.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonReinhard @szabo137