-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZSA integration (step 3): Add initial Transaction V6 support to Zebra (currently copies V5 behavior) #16
base: zsa-integration-zsadeps
Are you sure you want to change the base?
ZSA integration (step 3): Add initial Transaction V6 support to Zebra (currently copies V5 behavior) #16
Changes from 29 commits
054e655
a3a61f5
83d981b
c8fa779
2d23d6b
9d6c8e9
53c65b6
c67e2ae
c238847
2c13ae9
5a839c6
367a14b
f425747
831c847
ecaf98d
7d11159
6a0196e
8e53d24
1526276
654b8d4
9e94dc5
a6405d7
12ade98
a09774e
a026dd2
bb1395c
8d18425
f90a10f
9e5a01c
9e51b24
a158e9f
bed9fb5
164e5de
8195426
4ad68ae
b219b66
08de3de
f16bd20
51eaeda
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,3 +11,10 @@ pub const SAPLING_VERSION_GROUP_ID: u32 = 0x892F_2085; | |
/// Orchard transactions must use transaction version 5 and this version | ||
/// group ID. Sapling transactions can use v4 or v5 transactions. | ||
pub const TX_V5_VERSION_GROUP_ID: u32 = 0x26A7_270A; | ||
|
||
/// The version group ID for version 6 transactions. | ||
/// | ||
/// Orchard transactions must use transaction version 5 and this version | ||
/// group ID. | ||
// FIXME: use a proper value! | ||
pub const TX_V6_VERSION_GROUP_ID: u32 = 0x26A7_270B; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's use a random number in the meanwhile. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Optional: It's There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Temporarily changed to 0x7777_7777 to align with the a new value used in librustzcash (zcash_primitives) and test vectors. Kept a FIXME comment to change it in the future. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Temporarily changed to 0x124A_69F8 to align with the a value used in OLD version of librustzcash (zcash_primitives) and test vectors. Kept a FIXME comment to change it in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to this comment copied to #37.