Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a batch_size bug in attack_args.py #735

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

Falanke21
Copy link
Contributor

This change fixes the bug where "--model-batch-size" doesn't function when "--attack-recipe" argument is present.

What does this PR do?

This change fixes the bug where "--model-batch-size" doesn't function when "--attack-recipe" argument is present.

Additions

  • *Example: Added a line to set goal_function.batch_size to model_batch_size argument.

Deletions

None.

Checklist

  • [ ] The title of your pull request should be a summary of its contribution.
  • [ ] Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • [ ] If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • [ ] To indicate a work in progress please mark it as a draft on Github.
  • [ ] Make sure existing tests pass.
  • [ ] Add relevant tests. No quality testing = no merge.
  • [ ] All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

This change fixes the bug where "--model-batch-size" doesn't function when "--attack-recipe" argument is present.
Copy link

@simonucl simonucl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line works for changing the batch size with the latest release.

@simonucl
Copy link

simonucl commented Aug 3, 2023

@jxmorris12 Dear admin, thanks for your implementation for the tools. I used this repository for research and this PR fixes my problem, would be great if this could be merged into the master branch.

@jxmorris12 jxmorris12 merged commit 2abb4dd into QData:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants