Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/playable rawdata #264

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Feature/playable rawdata #264

merged 2 commits into from
Dec 16, 2023

Conversation

EvieePy
Copy link
Member

@EvieePy EvieePy commented Dec 16, 2023

Description

Add a raw_data field to Playable to allow retrieving the raw data received via Lavalink.
Playable can be constructed with this data.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

chillymosh
chillymosh approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@chillymosh chillymosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvieePy EvieePy merged commit dcd61d7 into main Dec 16, 2023
6 checks passed
@EvieePy EvieePy deleted the feature/playable-rawdata branch December 16, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chillymosh chillymosh chillymosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvieePy @chillymosh