Start of attempted Queue refactor. #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add more docstrings. - Change the Queue's internal list to a single-underscore-prefixed name. - Add some "fast" paths when putting stuff in the queue? - Experiment with TypeGuard. Will probably be removed later.
8 tasks
|
Closing as this was implemented in #280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to start a refactor for
wavelink.Queueto use an internal list instead of an internal deque.It should allow users to use the Queue in more ways that need fast random access. Changes are based on the pre-existing queue and this rough layout by Mysty in the Wavelink Discord dev channel.
(Side note: Part of the reason this is a draft is because it feels like a mess at the moment.)