Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue during the parsing of "badbins" #66

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

AbstractUmbra
Copy link
Collaborator

@AbstractUmbra AbstractUmbra commented Jul 31, 2024

Description

This PR corrects the behaviour which was added to parse content from "badbins", the likes of pastebin and hastebin and send them to mystb.in.
The problem is that previous iterations of mystbin returns a "notice" field in the response, we used to use that to notice the pasting user of their notice. This is no longer the case.

The code was previously updated to account for this, but further in the on_message listener we attempt to unpack the return of the function which previously returned a tuple[str, str], but now only returns str.

Pyright did not catch this, believing that foo, bar = "baz" to be valid in this case, which it was not.

This corrects that, as well as bad code smells.

EDIT: Our ruff action isn't version bound, so I've had to update, run and correct code around ruff. I can split this into a separate PR if necessary.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

@AbstractUmbra AbstractUmbra added the bug Something isn't working label Jul 31, 2024
@AbstractUmbra AbstractUmbra self-assigned this Jul 31, 2024
@EvieePy EvieePy merged commit 495fbd8 into main Aug 1, 2024
2 checks passed
@EvieePy EvieePy deleted the fix/Xbin-parsing branch August 1, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants