Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Implement the continuous entropic mapping #613

Merged
merged 7 commits into from
Mar 29, 2024
Merged

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Mar 8, 2024

Types of changes

This is a long needed implementation of the Entropic OT mapping from

[66] Pooladian, Aram-Alexandre, and Jonathan Niles-Weed. Entropic estimation of optimal transport maps. arXiv preprint arXiv:2109.12004 (2021).

[19] Seguy, V., Bhushan Damodaran, B., Flamary, R., Courty, N., Rolet, A.& Blondel, M. Large-scale Optimal Transport and Mapping Estimation. International Conference on Learning Representation (2018)

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Merging #613 (ebcf796) into master (63e44e5) will increase coverage by 0.01%.
The diff coverage is 98.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
+ Coverage   96.78%   96.79%   +0.01%     
==========================================
  Files          77       77              
  Lines       16027    16086      +59     
==========================================
+ Hits        15511    15570      +59     
  Misses        516      516              

@rflamary rflamary changed the title [WIP] Implement the continuous entropic mapping [MRG] Implement the continuous entropic mapping Mar 8, 2024
Copy link
Collaborator

@cedricvincentcuaz cedricvincentcuaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments to complete the PR and clear few doubts on the method. All computations are in adequation with papers' formulas so no problem on this side.

ot/da.py Outdated Show resolved Hide resolved
ot/da.py Show resolved Hide resolved
ot/da.py Show resolved Hide resolved
ot/da.py Show resolved Hide resolved
@rflamary rflamary merged commit ab12dd6 into master Mar 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants