[MRG] fix gpu compatibility of srGW solvers #596
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Tests on the first marginal within sr(F)GW solvers were not compatible with gpu usage as
np.testing.assert_allclose(nx.sum(G0, 1), p, atol=1e-08)
implies that variables are converted to numpy and stored on cpu before the test. This test fails if it requires first to move variables from gpu to cpu.
Fix:
assert nx.allclose(nx.sum(G0, 1), p, atol=1e-08)
Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist