Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Low rank sinkhorn algorithm #568
[MRG] Low rank sinkhorn algorithm #568
Changes from 30 commits
f49f6b4
3c4b50f
3034e57
085863a
9becafc
855234d
6ea251c
965e4d6
fd5e26d
3df3b77
fae28f7
ab5475b
f1c8cdd
b1a2136
9e51a83
df01cff
a0b0a9d
7075c8b
5f2af0e
5bc9de9
c66951b
6040e6f
a7fdffd
d90c186
ea3a3e0
f6a36bf
fe067fd
5d3ed32
3e6b9aa
165e8f5
de54bb9
bdcfaf6
d0d9f46
ec96836
8c6ac67
fafc5f6
bc7af6b
b40705c
55c8d2b
218c54a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you specify the parameters here too ?
Check warning on line 64 in ot/lowrank.py
Codecov / codecov/patch
ot/lowrank.py#L64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is more conventional in POT API, to set a
None
value as default such as:rank: int, optional. Default is None. Nonnegative rank of the OT plan. If None, min(ns, nt) is considered.
Same template for
alpha
.NB: the rank actually has to be strictly positive.
Check warning on line 216 in ot/lowrank.py
Codecov / codecov/patch
ot/lowrank.py#L216
Check warning on line 218 in ot/lowrank.py
Codecov / codecov/patch
ot/lowrank.py#L218
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if rank is None:
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same