Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add kl_loss to all semi-relaxed (f)gw solvers #559

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

cedricvincentcuaz
Copy link
Collaborator

Types of changes

  • Add loss_fun="kl_loss" to all semi-relaxed (f)gw solvers.
  • line-search for conditional gradient solvers solve_semirelaxed_gromov_linesearch now support any decomposable functions as for gromov-wasserstein : implied to add a parameter fC2t (which corresponds to $f_2(C_2)^\top$ in this note). Previously existing parameters $C_1$ and $C_2$ should be past $h_1(C_1)$ and $h_2(C_2)$ as values - this is explained in the function documentation.

Motivation and context / Related issue

How has this been tested (if it applies)

  • Extended most existing tests for these functions by looping over admissible values of loss_fun.

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #559 (c2e5d4d) into master (a73ad08) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files          67       67           
  Lines       14663    14669    +6     
=======================================
+ Hits        14149    14155    +6     
  Misses        514      514           

@cedricvincentcuaz cedricvincentcuaz merged commit 1071759 into PythonOT:master Nov 4, 2023
13 checks passed
@cedricvincentcuaz cedricvincentcuaz deleted the srgw_kl branch November 4, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant