[MRG] Change Doc empirical_sinkhorn_div to reflect what is computed #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c term is not taken into account.
rflamary
changed the title
|
Same issue as PR #422 with the doc (pbm with |
rflamary
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…c term is not taken into account.
Types of changes
Added a short mention in the doc of
ot.bregman.empirical_sinkhorn_divergenceto mention that the entropic contribution is not taken into account.Motivation and context / Related issue
Suggested by @rflamary in Issue #421 . Did an independent PR to avoid confusion with the corresponding fix.
PR checklist