[MRG] MM algorithms for UOT #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
==========================================
- Coverage 93.78% 93.78% -0.01%
==========================================
Files 23 23
Lines 5845 5902 +57
==========================================
+ Hits 5482 5535 +53
- Misses 363 367 +4 |
rflamary
reviewed
Apr 8, 2022
There was a problem hiding this comment.
Thank you @lchapel this is a very nice PR.
could you pease add a few more tests to check for special cases ?
also I'm not sure why the doc is not building but please check locally that the new function give a proper documentation.
|
|
||
| while (err > stopThr and cpt < numItermax): | ||
| Kprev = K | ||
| K = K * q1 |
There was a problem hiding this comment.
What is all this? was the implementation false? why is there so much more steps?
ot/unbalanced.py
Outdated
| if G0 is None: | ||
| G = a[:, None] * b[None, :] | ||
| else: | ||
| G = G0 |
There was a problem hiding this comment.
Please also test with G0 not given and with a and b =[]
| log['err'].append(err) | ||
| log['G'].append(G) | ||
| if verbose: | ||
| print('{:5d}|{:8e}|'.format(i, err)) |
| verbose=verbose, log=True) | ||
|
|
||
| if log: | ||
| return log_mm['cost'], log_mm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and context / Related issue
How has this been tested (if it applies)
pep8 + doctest
PR checklist