-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Implementation of two news algorithms: SaGroW and PoGroW. #275
Conversation
…sserstein and Pointwise Gromov Wasserstein.
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 93.34% 93.06% -0.28%
==========================================
Files 17 17
Lines 3547 3679 +132
==========================================
+ Hits 3311 3424 +113
- Misses 236 255 +19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hell @Hv0nnus and thank you very much for this PR.
I did a code review to ensure that the integration in POT and its documentation is seamless, there are a few things to do but I'm confident we can merge soon.
Yes I agree, could you please open an issus with this? I think is should be corrected by setting the seed in the test but it should also be looked at because there is clearly a fail condition on this mapping estimation. |
Add two new algorithms to solve Gromov Wasserstein: Sampled Gromov Wasserstein and Pointwise Gromov Wasserstein. Based on Sampled Gromov Wasserstein (Machine Learning Journal 2021) (https://hal.archives-ouvertes.fr/hal-03232509/document).
Types of changes
Motivation and context / Related issue
How has this been tested (if it applies)
It has been tested on some GW problems, with various values of hyper-parameters.Checklist