Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for input import before running FixInput #519

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Add check for input import before running FixInput #519

merged 1 commit into from
Oct 24, 2019

Conversation

Ionaru
Copy link
Contributor

@Ionaru Ionaru commented Oct 23, 2019

Check if from builtins import input is already present (result of raw_input fixer) and skip the input fixer if it does.

Fixes #427

@Ionaru
Copy link
Contributor Author

Ionaru commented Oct 23, 2019

The test TestFuturizeSimple::test_input_without_import fails on Py26, I don't know why.
@jmadler @anikamukherji any idea?

I wouldn't be against dropping Py26 support with #496 though 😛

@jmadler
Copy link
Contributor

jmadler commented Oct 24, 2019

@Ionaru - The failure looks unrelated. I'd prefer we not drop Py26 support until absolutely necessary.

I'll merge it in and follow-up on the Py26 test failure.

@jmadler jmadler merged commit 615ee1e into PythonCharmers:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raw_input breaking with multiple futurize passes
2 participants