to allow "default" parameter in min and max issue 334 #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2019 11:50
jmadler
suggested changes
May 7, 2019
src/future/builtins/misc.py
Outdated
| @@ -13,6 +13,8 @@ | |||
| - ``open`` (equivalent to io.open on Py2) | |||
| - ``super`` (backport of Py3's magic zero-argument super() function | |||
| - ``round`` (new "Banker's Rounding" behaviour from Py3) | |||
| - ``max`` (new max behaviour from Py3) | |||
There was a problem hiding this comment.
Suggested change
| - ``max`` (new max behaviour from Py3) | |
| - ``max`` (new default option from Py3) |
src/future/builtins/misc.py
Outdated
| @@ -13,6 +13,8 @@ | |||
| - ``open`` (equivalent to io.open on Py2) | |||
| - ``super`` (backport of Py3's magic zero-argument super() function | |||
| - ``round`` (new "Banker's Rounding" behaviour from Py3) | |||
| - ``max`` (new max behaviour from Py3) | |||
| - ``min`` (new min behaviour from Py3) | |||
There was a problem hiding this comment.
Suggested change
| - ``min`` (new min behaviour from Py3) | |
| - ``min`` (new default option from Py3) |
tests/test_future/test_builtins.py
Outdated
| @@ -138,6 +138,7 @@ def test_round(self): | |||
| self.assertEqual(round(0.125000001, 2), 0.13) | |||
| self.assertEqual(round(123.5, 0), 124.0) | |||
| self.assertEqual(round(123.5), 124) | |||
| self.assertEqual(round(123.5), 124) | |||
There was a problem hiding this comment.
Suggested change
| self.assertEqual(round(123.5), 124) |
|
Looks like test failures are unrelated. Thanks for implementing! :) |
|
Thanks Jordan! It is my first open source contribution. Thanks for helping
me out :)
On Tue, May 7, 2019 at 4:25 PM Jordan M. Adler ***@***.***> wrote:
Merged #459 <#459>
into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#459 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADLGNH74TJ6CYTU7IFTDNXLPUHQSJANCNFSM4HLLFWMQ>
.
--
Being receptive is different from being fickle.
|
|
It was my pleasure! You did an excellent job and surpassed my expectations. Thank you for your help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.