-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Get SCIP solving time considering float number with some text #3234
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3234 +/- ##
=======================================
Coverage 88.39% 88.40%
=======================================
Files 848 848
Lines 95322 95322
=======================================
+ Hits 84259 84267 +8
+ Misses 11063 11055 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@henriquejsfj - Thanks for this PR! We think this looks fine. We test against SCIP 8.0 on our Jenkins, not 9.0, so we don't have a test to verify this behavior. Is it possible for you to add a small test for this edge case? Unrelated: can you please edit the PR description to add back in the template? The legal acknowledgement is a requirement. As for the failing test, that is unrelated. I have a different PR up to fix that. |
@mrmundt Thanks for your reply. I tested an example from docs and it was working, so I investigated and found the edge case: solver = SolverFactory("scip")
solver.options['reoptimization/enable'] = True By adding this option both SCIP 8 and 9 will return that bigger string breaking the code. Previously, when I used SCIP 7 with Pyomo 6.3 I had no issues. |
@henriquejsfj - I stand corrected! We do have SCIP 9.0 available on one test suite in GHA - |
This fix does not change previous behavior and handles the case of a string with a float number plus some text.
@mrmundt - Sure, just added it. It is always a good idea to add a test case to a bug that was not caught before! |
This fix does not change previous behavior and handles the case of a string with a float number plus some text.
Fix #3233
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: