-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use openapi-core 0.19.0 #220
Conversation
Side note - should |
Yes, please. |
@miketheman: this looks much better than I hoped! Was afraid a bigger rewrite was needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got everything passing make all
.
I'm not super familiar with nix-shell or how to update the stack correctly - I spent a few hours trying to figure it out, but ended up more confused than when I started.
@miketheman: can you give me write permissions to your fork, so I can push CI/nix fixes? Also, could you rebase it off of latest |
Includes updates to other dependencies. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
6.0 install was failing for `cython_sources`, similar to yaml/pyyaml#736 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Not a final changeset, only a stepping-stone to the next version. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Not all tests pass, see following commits. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Refs: python-openapi/openapi-core#690 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
This reverts commit 8eae13c.
`InvalidCustomFormatterValue` grows in scope of responsibility, as `FormatUnmarshalError` is no longer available. Refs: python-openapi/openapi-core#562 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
9775bbc
to
02267d0
Compare
Rebased, and invitation sent! |
@miketheman: CI found some failing tests in the examples/ folder. I fixed one, but ran out of time to do the rest, and I can't do any further work today. |
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
The underlying openapi-code library changed how they pass back the response body in 0.19 Refs: python-openapi/openapi-core#710 Co-authored-by: Wim De Clercq <declewi@gmail.com> Signed-off-by: Mike Fiedler <miketheman@gmail.com>
f615095
to
04cbaa5
Compare
@zupo Our powers combined, it's working! With the change to drop Python 3.8, please update the branch protection requirements to remove "Python 3.8 Tests". |
Plus a bunch of gardening: * leaftovers cleanup from #220, * update thelist of projects using pyramid_openapi3, * update the dev env to latest packages,
Plus a bunch of gardening: * leaftovers cleanup from #220, * update thelist of projects using pyramid_openapi3, * update the dev env to latest packages,
Plus a bunch of gardening: * leaftovers cleanup from #220, * update thelist of projects using pyramid_openapi3, * update the dev env to latest packages,
Plus a bunch of gardening: * leaftovers cleanup from #220, * update thelist of projects using pyramid_openapi3, * update the dev env to latest packages,
This is an incomplete PR, but I wanted to share where I've gotten to so far.
A lot of the foundations are based on work done in #206
This includes the assumption of remaining OpenAPI 3.0 compliant (which we can absolutely change going forward), I wanted to get as close as I could to pyramid_openapi3 0.16 before doing so - and get some clean test passes.
I had to skip a few tests to complete the pass, which I consider insufficient for merge, so I've left some TODO and FIXME inline with some notes, and would appreciate any pointers to help resolve.
I tried to split commits out to show the work done at each step, hopefully that will make reviewing easier.