Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace config.set_request_property by config.add_request_method #31

Closed
wants to merge 1 commit into from
Closed

Replace config.set_request_property by config.add_request_method #31

wants to merge 1 commit into from

Conversation

arnaud-morvan
Copy link

For compatibility with pyramid 1.10

@stevepiercy
Copy link
Member

@arnaud-morvan there is a failing test in the build that needs to be fixed.

@arnaud-morvan
Copy link
Author

@mmerickel @stevepiercy : Thanks for review, I fixed the test, seems that pep8 errors are not related with the PR but already in master.
Could you have a look at : #29

@digitalresistor
Copy link
Member

Would you mind rebasing this change on master?

@digitalresistor
Copy link
Member

Actually I believe this was fixed in #33, please re-open if not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmerickel mmerickel mmerickel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arnaud-morvan @stevepiercy @digitalresistor @mmerickel