Fix to handle non-ascii characters in platform version shown in Versions panel. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-ascii characters in platform name, for example Fedora's <<Schrödinger’s Cat>> causes VersionDebugPanel to fail with UnicodeDecodeError. Added compat.text_(.., 'utf8') convertion and moved platform name discovery to helper method to be easily swaped in unit tests.
|
The patch looks pretty good. For future reference, please avoid mixing whitespace changes with substanntive ones: they make review trickier than necessary. Can you please add a description of the change in 'CHANGES.txt'? Thank! |
|
All tests pass (with the 38cc717 patch). I recommend to add the following line to CHANGES.txt while merging:
|
|
Thank you, it's merged! |
This was referenced Feb 26, 2017
This was referenced Mar 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-ascii characters in platform name, for example Fedora's <<Schrödinger’s Cat>>
causes VersionDebugPanel to fail with UnicodeDecodeError. Added compat.text_(.., 'utf8')
convertion and moved platform name discovery to helper method to be easily swaped in unit tests.