Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this turned into a bit of a rabbit hole cleaning up a lot of cruft in the toolbar with regard to exceptions.
Tracebacks are now tied to the per-request toolbar object one-to-one. A request may have one traceback. Previously they actually stuck around for the entire lifetime of the app instead of being collected by the
max_request_history
setting.The routes for exceptions are standardized to look similar to the SQLA ajax routes. For example,
/{request_id}/exception
instead of/exception?token=...&tb=...
and/{request_id}/exception/execute/{frame_id}?cmd=...
instead of/exception?token=...&tb=...&frm=...&cmd=...
.Fixed the url generation for the traceback panel link at the bottom of the traceback... it was actually empty previously - it got lost somewhere along the way.
/favicon.ico
is no longer specially handled.. it's just part ofexclude_prefixes
like anything else that you want to exclude.request.pdtb_history
is available for toolbar requests (mostly ajax requests or panel rendering).Removed the unused history predicate.
URL generation was broken in the
debugger.js
but that's fixed now so the execute/source buttons work in tracebacks.