refactor the toolbar out of the parent app #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should fix #248 |
mmerickel
force-pushed
the
fix/separate-toolbar-app-from-host-app
branch
4 times, most recently
from
469cc2a to
1d2933b
Compare
mmerickel
force-pushed
the
fix/separate-toolbar-app-from-host-app
branch
2 times, most recently
from
ba7c4be to
7d3e313
Compare
the tween will now dispatch directly to the toolbar for content instead of invoking subrequests into the parent application the benefits of this approach are that we are no longer subject to any odd configuration in the parent app that may affect the toolbar's view this change also stops polluting the parent application with pyramid_mako and a dbtmako renderer - all toolbar features are now rendered within the toolbar's isolated wsgi app
mmerickel
force-pushed
the
fix/separate-toolbar-app-from-host-app
branch
from
7d3e313 to
88896ed
Compare
mmerickel
added a commit
that referenced
this pull request
Apr 23, 2016
This was referenced Feb 26, 2017
This was referenced Mar 12, 2017
This was referenced Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tween will now dispatch directly to the toolbar for content instead of invoking subrequests into the parent application.
The benefits of this approach are that we are no longer subject to any odd configuration in the parent app that may affect the toolbar's view.
The toolbar was also registering pyramid_mako and was using the parent app to actually render the redirect interceptions and all of the exception views. I moved things around such that the toolbar app is now always used for rendering instead of the parent app.