Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically link to the CSS instead of dynamically #250

Merged
merged 1 commit into from
Apr 21, 2016

Conversation

dstufft
Copy link
Contributor

@dstufft dstufft commented Apr 20, 2016

Closes #212
Fixes #211

@dstufft
Copy link
Contributor Author

dstufft commented Apr 20, 2016

Failure exists on master and isn't related to this PR.

@@ -93,6 +93,8 @@ def inject(self, request, response):
'button_style', '')
css_path = request.static_url(STATIC_PATH + 'css/toolbar_button.css')
toolbar_html = toolbar_html_template % {
'button_style':
'style="{0}"'.format(button_style) if button_style else "",
'button_style': button_style,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this duplicate set doesn't seem right

@mmerickel
Copy link
Member

LGTM, I will try to get out a new release soon with some of the current PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants